Vybe (Coding Agent) vybe
  • Joined on 2026-05-17
vybe closed issue jtmorris/dms_tailscalectl#46 2026-05-22 03:14:21 +00:00
Error paths are inconsistent across Process handlers
vybe commented on issue jtmorris/dms_tailscalectl#50 2026-05-22 03:14:21 +00:00
propagateComposedEvents on right-click MouseArea is a footgun

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

vybe closed issue jtmorris/dms_tailscalectl#44 2026-05-22 03:14:20 +00:00
Timer continues polling after tailscale binary disappears or fails
vybe commented on issue jtmorris/dms_tailscalectl#44 2026-05-22 03:14:20 +00:00
Timer continues polling after tailscale binary disappears or fails

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

vybe commented on issue jtmorris/dms_tailscalectl#46 2026-05-22 03:14:20 +00:00
Error paths are inconsistent across Process handlers

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

vybe commented on issue jtmorris/dms_tailscalectl#41 2026-05-22 03:14:19 +00:00
makeExitNodeCommand("") emits invalid tailscale command

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

vybe closed issue jtmorris/dms_tailscalectl#41 2026-05-22 03:14:19 +00:00
makeExitNodeCommand("") emits invalid tailscale command
vybe commented on issue jtmorris/dms_tailscalectl#40 2026-05-22 03:14:18 +00:00
for...in loops without hasOwnProperty guard in lib.js

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

vybe closed issue jtmorris/dms_tailscalectl#40 2026-05-22 03:14:18 +00:00
for...in loops without hasOwnProperty guard in lib.js
vybe closed issue jtmorris/dms_tailscalectl#38 2026-05-22 03:14:17 +00:00
statusCheck parses stdout in onStreamFinished before onExited validates exit code
vybe commented on issue jtmorris/dms_tailscalectl#38 2026-05-22 03:14:17 +00:00
statusCheck parses stdout in onStreamFinished before onExited validates exit code

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

vybe pushed to vibes at jtmorris/dms_tailscalectl 2026-05-22 03:13:48 +00:00
d85c4b914e Merge batch fixes: security, QML Process, Timer, and plugin.json (#38, #40, #41, #44, #46, #50, #51)
d2e9069ce5 fix: remove binaryAvailable, fix statusCheck parser location, add timer guard
0d381751bf fix: remove propagateComposedEvents and fix plugin author (#50, #51)
dca1039c51 fix: lib.js security and correctness fixes (#40, #41)
Compare 4 commits »
vybe pushed to feature_batch6_remaining at jtmorris/dms_tailscalectl 2026-05-21 21:13:17 +00:00
30de75ff06 fix: remove binaryAvailable, fix statusCheck parser location, add timer guard
vybe closed issue jtmorris/dms_tailscalectl#52 2026-05-21 19:59:53 +00:00
tailscale binary invoked via PATH with no absolute path or sandboxing
vybe commented on issue jtmorris/dms_tailscalectl#52 2026-05-21 19:59:00 +00:00
tailscale binary invoked via PATH with no absolute path or sandboxing

I agree with this assessment. My earlier "partial fix" for #52 was wrong — it reintroduced the exact binaryAvailable anti-pattern we already removed in #11, and I should have caught that…

vybe commented on issue jtmorris/dms_tailscalectl#52 2026-05-21 19:05:55 +00:00
tailscale binary invoked via PATH with no absolute path or sandboxing

Partially addressed in PR #53. Added binaryAvailable property that flips to false when statusCheck exits with code 127, and toggleTailscale()/setExitNode() now short-circuit with a toast…

vybe commented on issue jtmorris/dms_tailscalectl#51 2026-05-21 19:05:00 +00:00
plugin.json contains unprofessional author string

Fixed in PR #53. Replaced author string with just "John Morris".

No remaining work for this issue.

vybe commented on issue jtmorris/dms_tailscalectl#50 2026-05-21 19:04:15 +00:00
propagateComposedEvents on right-click MouseArea is a footgun

Fixed in PR #53. Removed propagateComposedEvents: true from the right-click MouseArea. The property was documented as intentional but serves no functional purpose — the right-click handler…

vybe commented on issue jtmorris/dms_tailscalectl#46 2026-05-21 19:03:29 +00:00
Error paths are inconsistent across Process handlers

Fixed in PR #53. All four Process handlers (toggleProcess, copyProcess, exitNodeProcess, statusCheck) now follow the same pattern: check code !== 0, show a toast with `TailscaleLib.erro…

vybe commented on issue jtmorris/dms_tailscalectl#44 2026-05-21 19:02:41 +00:00
Timer continues polling after tailscale binary disappears or fails

Fixed in PR #53. Added refreshTimer ID and guarded the trigger with if (!statusCheck.running) so the timer won't spawn a new tailscale status process while one is already running. Also added…