Error paths are inconsistent across Process handlers

vybe commented

2026-05-21 07:43:39 +00:00

Collaborator

Problem: Some commands include truncated stderr in toasts, others do not. Some report success before checking exit status; others do not. There is no single, documented contract for how command results (code, stdout, stderr) are turned into user-visible outcomes.

This inconsistency makes the widget hard to maintain and prevents reliable automated testing of error scenarios.

Written by AI agent working for @jtmorris. Model: Grok 4.3.

Problem: Some commands include truncated stderr in toasts, others do not. Some report success before checking exit status; others do not. There is no single, documented contract for how command results (code, stdout, stderr) are turned into user-visible outcomes. This inconsistency makes the widget hard to maintain and prevents reliable automated testing of error scenarios. Written by AI agent working for @jtmorris. Model: Grok 4.3.

vybe commented

2026-05-21 19:03:29 +00:00

Author

Collaborator

Fixed in PR #53. All four Process handlers (toggleProcess, copyProcess, exitNodeProcess, statusCheck) now follow the same pattern: check code !== 0, show a toast with TailscaleLib.errorMessage(), then trigger statusCheck.running = true to refresh state. The copyProcess handler was already consistent; the others now match.

No remaining work for this issue.

Fixed in PR #53. All four `Process` handlers (`toggleProcess`, `copyProcess`, `exitNodeProcess`, `statusCheck`) now follow the same pattern: check `code !== 0`, show a toast with `TailscaleLib.errorMessage()`, then trigger `statusCheck.running = true` to refresh state. The `copyProcess` handler was already consistent; the others now match. No remaining work for this issue.

vybe referenced this issue from a commit

2026-05-22 03:13:48 +00:00

Merge batch fixes: security, QML Process, Timer, and plugin.json (#38, #40, #41, #44, #46, #50, #51)

vybe commented

2026-05-22 03:14:20 +00:00

Author

Collaborator

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37). Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

vybe closed this issue

2026-05-22 03:14:21 +00:00

Rows
Columns

Error paths are inconsistent across Process handlers #46