Missing edge-case tests for parsePeers and findActiveExitNode

vybe commented

2026-05-19 04:18:45 +00:00

Collaborator

Problem

The test suite (test/lib.test.js) only exercises happy-path inputs for parsePeers and findActiveExitNode. There is no coverage for:

parsePeers(null), parsePeers(undefined), parsePeers({})
Peer entries missing TailscaleIPs or HostName
findActiveExitNode(null) or findActiveExitNode({})

Impact

The helper functions may throw, return surprising values, or produce incorrect output on edge-case inputs that can occur in real tailscale status --json responses. The current tests give a false sense of completeness.

## Problem The test suite (`test/lib.test.js`) only exercises happy-path inputs for `parsePeers` and `findActiveExitNode`. There is no coverage for: - `parsePeers(null)`, `parsePeers(undefined)`, `parsePeers({})` - Peer entries missing `TailscaleIPs` or `HostName` - `findActiveExitNode(null)` or `findActiveExitNode({})` ## Impact The helper functions may throw, return surprising values, or produce incorrect output on edge-case inputs that can occur in real `tailscale status --json` responses. The current tests give a false sense of completeness.

vybe referenced this issue

2026-05-19 04:30:56 +00:00

Lax / fragmented error handling throughout the widget (catch-all masking, missing exit checks, no stderr) #29

vybe commented

2026-05-19 05:22:07 +00:00

Author

Collaborator

Related: #12, #13, #14, #15, #29 — these core paths currently have no test coverage.

jtmorris commented

2026-05-19 05:23:36 +00:00

Owner

Yes. Very much agree that the current tests are minimally useful. Needs dramatic expansion to cover edge cases and drastically widen coverage, or it should be removed as code maintenance overhead, since it's fairly useless as is.

Worth thinking about which way to go. Probably expansion of tests, but I can see both sides.

Yes. Very much agree that the current tests are minimally useful. Needs dramatic expansion to cover edge cases and drastically widen coverage, or it should be removed as code maintenance overhead, since it's fairly useless as is. Worth thinking about which way to go. Probably expansion of tests, but I can see both sides.

vybe referenced this issue

2026-05-19 05:47:39 +00:00

Missing package.json declaring module type (ESM/CJS mismatch between tests and lib) #24

vybe referenced this issue from a commit

2026-05-21 07:05:34 +00:00

chore: JS quality batch (#20 for-in guard, #21 add edge tests, #22 dedup errorMessage keys)

vybe commented

2026-05-21 07:05:35 +00:00

Author

Collaborator

Added edge-case tests for parsePeers/findActiveExitNode in test/lib.test.js. Merged to vibes.