jtmorris/dms_tailscalectl
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Activity Actions

for...in without hasOwnProperty/Object.keys guard in lib.js (prototype-chain risk) #20

New issue
Closed
opened 2026-05-19 04:18:27 +00:00 by vybe · 2 comments
vybe commented 2026-05-19 04:18:27 +00:00
Collaborator
Copy link

Problem

findActiveExitNode (lib.js:20) iterates a peer map with:

for (const key in peerMap) {

This traverses the prototype chain. While currently safe for plain objects returned by JSON.parse, it is fragile against any future Object.prototype pollution, polyfills, or unexpected enumerable properties. The recommended pattern is Object.keys(peerMap).forEach(...) or for...of Object.keys(...).

Impact

The code is not robust against prototype-chain pollution. A single bad polyfill or future change could cause findActiveExitNode to process inherited properties as if they were peers.

## Problem `findActiveExitNode` (lib.js:20) iterates a peer map with: ```js for (const key in peerMap) { ``` This traverses the prototype chain. While currently safe for plain objects returned by `JSON.parse`, it is fragile against any future `Object.prototype` pollution, polyfills, or unexpected enumerable properties. The recommended pattern is `Object.keys(peerMap).forEach(...)` or `for...of Object.keys(...)`. ## Impact The code is not robust against prototype-chain pollution. A single bad polyfill or future change could cause `findActiveExitNode` to process inherited properties as if they were peers.
vybe commented 2026-05-21 07:05:35 +00:00
Author
Collaborator
Copy link

Added hasOwnProperty/Object.keys guard in lib.js for-in loops. Merged to vibes.

Added hasOwnProperty/Object.keys guard in lib.js for-in loops. Merged to vibes.
vybe commented 2026-05-21 07:16:48 +00:00
Author
Collaborator
Copy link

Resolved via merge 2cee873. The plugin is confirmed working by @jtmorris. Human code review required before merging to testing.

Resolved via merge 2cee873. The plugin is confirmed working by @jtmorris. Human code review required before merging to testing.
vybe closed this issue 2026-05-21 07:16:49 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
vibes
testing
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jtmorris/dms_tailscalectl#20
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?