Premature 'Copied' toast with no exit-status check on copyProcess

vybe commented

2026-05-19 04:10:12 +00:00

Collaborator

Problem

In copyToClipboard(), the success toast is shown immediately after starting the process:

copyProcess.running = true
ToastService.showInfo("Copied " + text + " to clipboard")

There is no onExited handler on copyProcess (unlike toggleProcess, exitNodeProcess, and statusCheck). The exit code is never inspected, so any failure of the clipboard command is reported as success.

Impact

Users are shown a false “Copied” confirmation even when the clipboard operation fails (missing binary, permission error, etc.).

## Problem In `copyToClipboard()`, the success toast is shown immediately after starting the process: ```js copyProcess.running = true ToastService.showInfo("Copied " + text + " to clipboard") ``` There is no `onExited` handler on `copyProcess` (unlike `toggleProcess`, `exitNodeProcess`, and `statusCheck`). The exit code is never inspected, so any failure of the clipboard command is reported as success. ## Impact Users are shown a false “Copied” confirmation even when the clipboard operation fails (missing binary, permission error, etc.).

vybe referenced this issue

2026-05-19 04:30:56 +00:00

Lax / fragmented error handling throughout the widget (catch-all masking, missing exit checks, no stderr) #29

vybe referenced this issue

2026-05-19 05:07:49 +00:00

Shell interpolation of clipboard detection output in TailscaleWidget.qml #12

vybe referenced this issue

2026-05-19 05:47:13 +00:00

Shell interpolation of clipboard detection output in TailscaleWidget.qml #12

vybe referenced this issue

2026-05-19 05:47:19 +00:00

Lax / fragmented error handling throughout the widget (catch-all masking, missing exit checks, no stderr) #29

vybe referenced this issue

2026-05-19 06:31:49 +00:00

Shell interpolation of clipboard detection output in TailscaleWidget.qml #12

vybe referenced this issue from a commit

2026-05-21 07:05:20 +00:00

chore: verify copyProcess already has proper onExited exit-status check + success toast

vybe referenced this issue from a commit

2026-05-21 07:05:20 +00:00

Merge feature_fix_copy_toast into vibes

vybe commented

2026-05-21 07:05:20 +00:00

Author

Collaborator

Verified: copyProcess onExited already performs exit code check and only shows success toast on code===0 with fallback rotation. No premature toast remains. Merged to vibes. Written by AI agent working for @jtmorris. Model: Grok 4.3.